[SYCL][NFC] Make kernel_impl::getAdapter() return by reference
#19313
+53
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
kernel_impl::getAdapter() return by reference
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This was referenced Jul 5, 2025
uditagarwal97
force-pushed
the
private/udit/adapterref7
branch
from
091d314 to
ddfba84
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
force-pushed
the
private/udit/adapterref7
branch
from
ddfba84 to
f8e59fe
Compare
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
reviewed
Jul 7, 2025
| @@ -469,7 +469,7 @@ void handleErrorOrWarning(ur_result_t Error, const device_impl &DeviceImpl, | |||
|
|
|||
| namespace detail::kernel_get_group_info { | |||
| void handleErrorOrWarning(ur_result_t Error, ur_kernel_group_info_t Descriptor, | |||
| const AdapterPtr &Adapter) { | |||
| adapter_impl &Adapter) { | |||
There was a problem hiding this comment.
Any reason to drop const?
There was a problem hiding this comment.
Previously, const was on shared_ptr<adapter_impl> and not the adapter_impl object itself. Ensuring const-correctness on adapter_impl object throughout the code would be orthogonal to the refactoring work that I'm doing and it's not trivial (I tried that before). So, for uniformity, throughout the refactoring, I've replaced const AdapterPtr with adapter_impl.
With that said, for the handleErrorOrWarning function specifically, since adapter_impl object is not passed around anywhere, I can add const adapter_impl& if that's desirable.
There was a problem hiding this comment.
Uniformity is fine with me. Thanks for the explanation!
| @@ -31,8 +31,7 @@ void handleErrorOrWarning(ur_result_t, const device_impl &, ur_kernel_handle_t, | |||
|
|
|||
| namespace kernel_get_group_info { | |||
| /// Analyzes error code of urKernelGetGroupInfo. | |||
| void handleErrorOrWarning(ur_result_t, ur_kernel_group_info_t, | |||
| const AdapterPtr &); | |||
| void handleErrorOrWarning(ur_result_t, ur_kernel_group_info_t, adapter_impl &); | |||
maarquitos14
approved these changes
Jul 8, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a part of larger refactoring effort to pass adapter via reference instead of pointer everywhere in the codebase.
Follow-up of:
#19186
#19184
#19187
#19202
#19299
#19312